https://github.com/dessalines/jerboa/issues/891

If you downvote any post in jerboa 0.0.35 you actually upvote it. Seems like anything gets merged? If this goes on like this, there could be a lot of trouble

Edit: Thanks to quick reaction seems like a simple an quick fix. I hope that things will be fine in the future

Edit 2: Commit is from 2022 January, so its understandable that it didn’t get as much review as it needed (https://github.com/dessalines/jerboa/commit/05fda4af1326a2f531a89542d07371b3ab8e7c4e)

  • catlover@sh.itjust.worksOP
    53·
    1 year ago

    I can totally understand the lack of people working on the project. As skeptic I am, I must say that you have total right to not believe me, but I’m an open source developer too with an own project, with literally no time at all since years. But what I’m trying to say: if the devs have no time to review PR-s, and features, please just don’t merge them at all. Please tell me that I’m wrong, but this seems like PR-s getting merged without proper reviews. This is far more worse than not merging any PR-s

    • Dandroid@dandroid.app
      1·
      1 year ago

      I haven’t looked through the Jerboa codebase very closely yet (I downloaded it, but that’s about as far as I have got so far), but it sounds like they either need more code coverage for their unit tests or they need to improve the quality of the unit tests. Good unit tests should catch a lot of bugs introduced by PRs. There is no QA team to do regression testing for each release, and the main developers can’t be expected to run manual testing for every PR. The developer of the PR should be doing that, but clearly they are not.